Actually --color-primary-element is FFFFFF which is okay on dark mode, so I guess the icons should be black/dark in those cases? Problem is in

I guess the icons should be black/dark in those cases

The idea was that instead of changing the foreground color, the background color should always stay the same as it is in light mode. But I think this is known by @pringelmann, I don't think this should block this unrelated fix.

@nickvergessen yes general dark mode compatibility is high on my TODO list. I will open successive PRs in the coming days to resolve these issues.

The idea was that instead of changing the foreground color, the background color should always stay the same as it is in light mode

I think its more about if you set you primary color to #ffffff or a very light color.
So the icons should have proper filter:

- filter: brightness(0) invert(1); 
+ filter: var(--primary-invert-if-bright);

(icons are bright by default so they need to invert to black if the primary background is bright)

Icon color fixed

My thinking was that icons might not always be white

It's kind of an implizit requirement since a long time and how the old navigation was also treating (and inverting) them in the row and the overflow menu 🙈
Thanks for addressing

@nickvergessen if you're happy with the change could you please approve? Merge is blocked by your change request